chore: added json schema for configuration file #2068
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportBase: 36.62% // Head: 36.56% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #2068 +/- ##
==========================================
- Coverage 36.62% 36.56% -0.07%
==========================================
Files 229 229
Lines 19539 19539
==========================================
- Hits 7156 7144 -12
- Misses 11547 11556 +9
- Partials 836 839 +3
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Bikappa
force-pushed
the
chore/json-schema
branch
9 times, most recently
from
724b3e3 to
d012145
Compare
Bikappa
force-pushed
the
chore/json-schema
branch
from
d012145 to
1f95eba
Compare
Bikappa
force-pushed
the
chore/json-schema
branch
from
1f95eba to
ed29087
Compare
umbynos
suggested changes
Feb 9, 2023
Bikappa
force-pushed
the
chore/json-schema
branch
from
ea69801 to
38231cd
Compare
umbynos
suggested changes
Feb 10, 2023
Bikappa
force-pushed
the
chore/json-schema
branch
from
c9eb6a4 to
8aa6453
Compare
umbynos
reviewed
Feb 13, 2023
per1234
requested changes
Feb 13, 2023
There was a problem hiding this comment.
UPDATE: Resolved by 8ad388e
per1234
requested changes
Feb 13, 2023
There was a problem hiding this comment.
UPDATE: superseded by 99eb639
Bikappa
force-pushed
the
chore/json-schema
branch
3 times, most recently
from
7134c2a to
34c68ce
Compare
Bikappa
force-pushed
the
chore/json-schema
branch
from
34c68ce to
99eb639
Compare
Co-authored-by: per1234 <[email protected]>
per1234
requested changes
Feb 16, 2023
…to chore/json-schema
Co-authored-by: per1234 <[email protected]>
Co-authored-by: per1234 <[email protected]>
per1234
requested changes
Feb 17, 2023
Co-authored-by: per1234 <[email protected]>
…to chore/json-schema
Co-authored-by: per1234 <[email protected]>
umbynos
approved these changes
Feb 22, 2023
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
See how to contribute
before creating one)
our contributing guidelines
UPGRADING.mdhas been updated with a migration guide (for breaking changes)What kind of change does this PR introduce?
Provides a json schema for the cli configuration file, for now the schema is not used by the runtime itself and it's only meant for users initiatives.
A possible followup of this pr is the autogeneration of the list of options in configuration.md
What is the current behavior?
What is the new behavior?
Does this PR introduce a breaking change, and is titled accordingly?
Other information
Fixes #587